Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared
From: Thomas Gleixner
Date: Sun Feb 12 2017 - 05:57:25 EST
On Sun, 12 Feb 2017, Tobin C. Harding wrote:
A few nitpicks.
> Subject: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared
arch/x86: is not the correct prefix. Run git log on a file to figure out
what the usual prefix is. The file was checked in with 'purgatory', but I'd
prefer 'x86/purgatory' for future changes.
> This patch adds static declaration to a number of variables. Fixes
> sparse symbol was not declared warnings.
Please read 'Documentation...SubmittingPatches' and look for 'This patch'.
I give you an example for a changelog:
Sparse emits several 'symbol not declared' warnings.
Make the variables and functions, which have only file scope static.
Now try to map that to the advise in Documentation.