Re: [PATCH] clocksource: add __ro_after_init to cyclecounter

From: Bhumika Goyal
Date: Sun Feb 12 2017 - 13:22:28 EST

On Sun, Feb 12, 2017 at 2:05 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Sun, 12 Feb 2017, Bhumika Goyal wrote:
> Please be more careful with your subject line. The prefix for this is
> definitely not 'clocksource'. git log would have told you the proper one:
> clocksource/drivers/arm_arch_timer
> 'clocksource' is the general subsystem and used for system wide changes or
> core changes, but not for a particular driver.

I will be more careful about this in future.


>> The object cyclecounter of type cyclecounter is not getting modified
>> after getting initialized by arch_counter_register. Apart from
>> initialization in arch_counter_register it is also passed as an argument
>> to the function timecounter_init but this argument is of type const.
>> Therefore, add __ro_after_init to its declaration.
> Other than that this is fine. I'll fix it up when applying.
> Thanks,
> tglx