Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API

From: Byungchul Park
Date: Mon Feb 13 2017 - 00:56:03 EST


On Mon, Feb 13, 2017 at 01:38:36PM +0800, Huang, Ying wrote:
> Hi, Byungchul,
>
> Byungchul Park <byungchul.park@xxxxxxx> writes:
>
> > Although llist provides proper APIs, they are not used. Make them used.
> >
> > Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
> > ---
> > drivers/md/bcache/closure.c | 15 ++-------------
> > drivers/md/raid5.c | 4 +---
> > drivers/vhost/scsi.c | 9 ++-------
> > fs/file_table.c | 12 +++++-------
> > fs/namespace.c | 12 +++++-------
> > include/linux/llist.h | 3 +++
> > kernel/irq_work.c | 6 +-----
> > kernel/sched/core.c | 13 ++-----------
> > mm/vmalloc.c | 8 +++-----
>
> I think you need to split the patch. One for each subsystem, this makes
> it easier to be reviewed and merged.

Thank you. I will do it.

>
> Best Regards,
> Huang, Ying
>
> [snip]