Re: [PATCH] Input: pwm-beeper: support customized freq for SND_BELL

[Heiko Schocher]

Hello Rob,

Am 10.02.2017 um 16:48 schrieb Rob Herring:
> On Tue, Feb 07, 2017 at 06:21:34AM +0100, Heiko Schocher wrote:
> > From: Guan Ben <ben.guan@xxxxxxxxxxxx>
> >
> > extend the pwm-beeper driver to support customized frequency
> > for SND_BELL from device tree.
> >
> > Signed-off-by: Guan Ben <ben.guan@xxxxxxxxxxxx>
> > Signed-off-by: Mark Jonas <mark.jonas@xxxxxxxxxxxx>
> > [hs@xxxxxxx: adapted to 4.10-rc7]
> > Signed-off-by: Heiko Schocher <hs@xxxxxxx>
> >
> > ---
> >
> >   .../devicetree/bindings/input/pwm-beeper.txt       |  3 ++
> >   drivers/input/misc/pwm-beeper.c                    | 36 ++++++++++++++++------
> >   2 files changed, 30 insertions(+), 9 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> > index be332ae..438c6e0 100644
> > --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
> > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> > @@ -5,3 +5,6 @@ Registers a PWM device as beeper.
> >   Required properties:
> >   - compatible: should be "pwm-beeper"
> >   - pwms: phandle to the physical PWM device
> > +
> > +optional properties:
> > +- bell-frequency:  bell frequency in Hz
>
> Needs a unit suffix:
> bell-frequency-hz or just bell-hz as hz implies frequency.
>
> Or maybe beeper-hz would be more consistant.

Ok, I change it to "beeper-hz". Are this all issues with this patch?

bye,
Heiko
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany