Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions

[Jiri Olsa]

On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> Fix below compile error:
> CC       util/scripting-engines/trace-event-perl.o
> In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
>                  from util/scripting-engines/trace-event-perl.c:31:
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
>         dTHX;   /* The function called below requires thread context */
> 			     ^
> cc1: all warnings being treated as errors
> 
> After digging perl5 repository, I find out that we will meet this compile error
> with perl from v5.21.1 to v5.25.4
> 
> Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> ---
>  tools/perf/util/scripting-engines/Build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
> index 6516e22..82d28c6 100644
> --- a/tools/perf/util/scripting-engines/Build
> +++ b/tools/perf/util/scripting-engines/Build
> @@ -1,6 +1,6 @@
>  libperf-$(CONFIG_LIBPERL)   += trace-event-perl.o
>  libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
>  
> -CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
> +CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
>  
>  CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
> -- 
> 1.8.5.6.2.g3d8a54e.dirty
>