Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled.

From: Borislav Petkov
Date: Mon Feb 13 2017 - 12:48:03 EST


On Mon, Feb 13, 2017 at 03:52:28PM +0300, Kirill A. Shutemov wrote:
> GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP
> is disalbed:
>
> arch/x86/kernel/vm86_32.c: In function âmark_screen_rdonlyâ:
> arch/x86/kernel/vm86_32.c:180:26: warning: unused variable âvmaâ
> [-Wunused-variable]
> struct vm_area_struct *vma = find_vma(mm, 0xA0000);
> ^~~
> It shoudln't really. The whole block has to be eliminated as
> pmd_trans_huge() is 0 if THP is disabled.
>
> Anyway, this trick seems make GCC happy.

Please run this commit message through a spellchecker - I see at least
three typos.

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Reported-by: JÃrÃmy Lefaure <jeremy.lefaure@xxxxxxxxxxxx>

Tested-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--