Re: [PATCH 2/2] arch/x86: Fix sparse warning symbol not declared
From: Thomas Gleixner
Date: Mon Feb 13 2017 - 16:24:22 EST
On Tue, 14 Feb 2017, Tobin Harding wrote:
> On Sun, Feb 12, 2017 at 12:06:47PM +0100, Thomas Gleixner wrote:
> > The proper solution is to have a local include file 'purgatory.h' and put
> > the declaration there. Include it in both files even if that's not required
> > for the ASM file. But that documents, that the function is used outside of
> > purgatory.c
> Blindly following instructions led to the bone headed patch I
> submitted yesterday (without building). Is there some way to include a
> C header in an ASM file that I do not know about?
Yes, you have to guard the function declaration with
I did not think about that when I suggested this. Brainslip :)
So yes, it's kinda pointless, but it still has documentatory value and
keeps the sparse build clean.
> Thanks for patiently pointing out how to write a commit log. May I
> please bother you with another small etiquette question. Should I
> have replayed to you as I have done so or should I have re-sent another
> patch (v3) with the mistakes fixed (and stated in the log that I did
> not know how to implement the suggestions).
All good. Either way works as long as you notice your own mistakes. It's
also fine to tell me that I suggested nonsense. :)