Re: [PATCH] tile: fix build failure

From: Sudip Mukherjee
Date: Mon Feb 13 2017 - 17:58:54 EST


On Tuesday 24 January 2017 04:56 PM, Chris Metcalf wrote:
On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:
From: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>

The build of tilegx allmodconfig was failing with errors like:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
static inline u64 mul_u32_u32(u32 a, u32 b)
^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
static inline u64 mul_u32_u32(u32 a, u32 b)
^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
static inline u64 mul_u32_u32(u32 a, u32 b)
^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
function 'mul_u32_u32' [-Werror=implicit-function-declaration]

The simplest solution was to include the types header file.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and
friends")
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
---

build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687

arch/tile/include/asm/div64.h | 1 +
1 file changed, 1 insertion(+)

Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxxxx>


linux-next is still failing for this error. Who will pick this up?

Regards
Sudip