[PATCH v3 1/2] x86/purgatory: Fix sparse warning, symbol not declared

From: Tobin C. Harding
Date: Mon Feb 13 2017 - 21:49:26 EST


Sparse emits several 'symbol not declared' warnings for various
functions and variables.

Add static keyword to functions and variables which have file scope
only. Remove definition to zero for each variable declared static
in accord with kernel standard.

Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
---
arch/x86/purgatory/purgatory.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/purgatory/purgatory.c b/arch/x86/purgatory/purgatory.c
index 25e068b..2a5f437 100644
--- a/arch/x86/purgatory/purgatory.c
+++ b/arch/x86/purgatory/purgatory.c
@@ -18,11 +18,11 @@ struct sha_region {
unsigned long len;
};

-unsigned long backup_dest = 0;
-unsigned long backup_src = 0;
-unsigned long backup_sz = 0;
+static unsigned long backup_dest;
+static unsigned long backup_src;
+static unsigned long backup_sz;

-u8 sha256_digest[SHA256_DIGEST_SIZE] = { 0 };
+static u8 sha256_digest[SHA256_DIGEST_SIZE] = { 0 };

struct sha_region sha_regions[16] = {};

@@ -39,7 +39,7 @@ static int copy_backup_region(void)
return 0;
}

-int verify_sha256_digest(void)
+static int verify_sha256_digest(void)
{
struct sha_region *ptr, *end;
u8 digest[SHA256_DIGEST_SIZE];
--
2.7.4