Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions

From: Michael Ellerman
Date: Tue Feb 14 2017 - 05:42:48 EST


Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx> writes:

> diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c
> index fce05a3..5c5ae66 100644
> --- a/arch/powerpc/kernel/kprobes.c
> +++ b/arch/powerpc/kernel/kprobes.c
> @@ -528,6 +528,8 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
>
> int __init arch_init_kprobes(void)
> {
> + test_emulate_step();
> +

I don't see any good reason why this is called from here.

So I'm inclined to just make test_emulate_step() a regular init call.

cheers