Re: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP

From: Boris Ostrovsky
Date: Tue Feb 14 2017 - 09:32:28 EST

On 02/14/2017 04:20 AM, Paul Durrant wrote:
My previous reply got bounced because my tablet insisted on using HTML...

-----Original Message-----

These need to be static. (I can fix it when committing.)

Ok, thanks.

And I am still not sure about using XEN_PAGE_SIZE. There is no
dependency in the hypervisor on buffers being page-sized, is there? If
not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a
reasonable value.

How about just setting it to 4096?

I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that.


PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4?


But I also had a question about patch 3 (commit message). I can make the change when committing as well but I need to make sure you are OK with it.