Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues
From: SIMRAN SINGHAL
Date: Wed Feb 15 2017 - 03:18:19 EST
On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
>> Yes, I totally agree with joe.
>>
>> But as there is no coding style issue in this patch.
>
> Style is more than just checkpatch conformity.
>
>> So, do I have to resend the complete patch series again?
>
> I'm not applying any of these so that's entirely up
> to Greg.
>
> Perhaps he might apply the first 5 patches and reject
> this one, maybe he might apply all the patches.
>
> In any case, do strive to develop some reasonable
> semblance of style and do more than just checkpatch
> suggested patches and find and fix some actual defect
> somewhere.
Joe, I am new to Linux kernel and just have basic knowledge of
C and C++.
For doing more than checkpatches I need to explore Linux kernel more,
so please suggest me some tasks that help me in exploring
Linux kernel, which helps me in building the better understanding of codes,
which I am finding difficult to understand so that I can do more than
just checkpatch.
Thanks,
Simran