Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

[Felipe Balbi]

Hi,

Roger Quadros <rogerq@xxxxxx> writes:
> To avoid checkpatch warnings with new patches let's
> start using the BIT() macro wherever possible.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> ---
>  drivers/usb/dwc3/core.h      | 192 +++++++++++++++++++++----------------------
>  drivers/usb/dwc3/dwc3-omap.c |  48 +++++------
>  drivers/usb/dwc3/gadget.h    |  20 ++---
>  3 files changed, 130 insertions(+), 130 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 14b7602..d514dca 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -65,7 +65,7 @@
>  #define DWC3_DEVICE_EVENT_OVERFLOW		11
>  
>  #define DWC3_GEVNTCOUNT_MASK	0xfffc
> -#define DWC3_GEVNTCOUNT_EHB	(1 << 31)
> +#define DWC3_GEVNTCOUNT_EHB	BIT(31)

don't you need to include <linux/bitops.h> for this?

-- 
balbi

Attachment: signature.asc
Description: PGP signature