Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller
From: Greg KH
Date: Wed Feb 15 2017 - 09:31:21 EST
On Wed, Feb 15, 2017 at 09:21:56AM +0100, peter enderborg wrote:
> On 02/14/2017 05:51 PM, Greg KH wrote:
> > On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderborg@xxxxxxxxxxxxxx wrote:
> >> From: Peter Enderborg <peter.enderborg@xxxxxxxxxxxxxx>
> >>
> >> This collects stats for shrinker calls and how much
> >> waste work we do within the lowmemorykiller.
> >>
> >> Signed-off-by: Peter Enderborg <peter.enderborg@xxxxxxxxxxxxxx>
> > Wait, what changed from the previous versions of this patch? Did you
> > take the review comments into consideration, or is this just a resend of
> > the original patches in a format that isn't corrupted?
> >
> > thanks,
> >
> > greg k-h
>
> This is just a send with git-send-email that seems to work better. Nothing
> else than tab-spaces should be different. I would like to have some positive
> feedback from google/android before I start to send updated patches to the list.
> If google are ready for the userspace solution this patch set is pointless for
> upstream kernel.
>
> Michal Hocko is very negative to hole thing, but we have addressed at least some
> issues he pointed out on the list in 2015. Is there any idea to continue?
If Michal rejected this solution, then I wouldn't be spending much time
on it at all. Instead, I strongly suggest you try to do what he pointed
out should be done instead. If that requires userspace help, great, try
that and see what happens.
thanks,
greg k-h