RE: [PATCH] staging: visorbus, replace init_timer with setup_timer

[Kershner, David A]

> -----Original Message-----
> From: Jiri Slaby [mailto:jslaby@xxxxxxx]
> Sent: Wednesday, February 15, 2017 11:04 AM
> To: Kershner, David A <David.Kershner@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Stefan Svinciak <xsvinc1@xxxxxxxxxx>; Jiri
> Slaby <jslaby@xxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; *S-Par-Maintainer
> <SParMaintainer@xxxxxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] staging: visorbus, replace init_timer with setup_timer
> 
> From: Stefan Svinciak <xsvinc1@xxxxxxxxxx>
> 
> Newer version is more readable and needs less changes if/when
> timer_struct is to be changed.
> 
> Signed-off-by: Stefan Svinciak <xsvinc1@xxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: David Kershner <david.kershner@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: <sparmaintainer@xxxxxxxxxx>
> Cc: <devel@xxxxxxxxxxxxxxxxxxxx>

Acked-by: David Kershner <david.kershner@xxxxxxxxxx>

Looks good and runs nicely on s-Par. 

David Kershner

> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index aea1aa262b28..55f29ae8e015 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -623,9 +623,7 @@ create_visor_device(struct visor_device *dev)
>  	dev->device.release = visorbus_release_device;
>  	/* keep a reference just for us (now 2) */
>  	get_device(&dev->device);
> -	init_timer(&dev->timer);
> -	dev->timer.data = (unsigned long)(dev);
> -	dev->timer.function = dev_periodic_work;
> +	setup_timer(&dev->timer, dev_periodic_work, (unsigned long)dev);
> 
>  	/*
>  	 * bus_id must be a unique name with respect to this bus TYPE
> --
> 2.11.1