Re: [PATCH] PCI: always build pci-host-common on ARM64
From: Arnd Bergmann
Date: Wed Feb 15 2017 - 17:01:42 EST
On Wed, Feb 15, 2017 at 5:56 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Tue, Feb 14, 2017 at 10:42:56PM +0100, Arnd Bergmann wrote:
>> The Thunder PCI host driver is always built, but it relies on pci_host_common_probe,
>> so we get a link error here:
>> drivers/pci/host/pci-thunder-pem.c: In function 'thunder_pem_probe':
>> drivers/pci/host/pci-thunder-pem.c:412:9: error: implicit declaration of function 'pci_host_common_probe';did you mean 'pci_host_bridge_priv'? [-Werror=implicit-function-declaration]
>> This adds the common file to the existing hack.
>> Fixes: ca5ab37b19df ("PCI: Explain ARM64 ACPI/MCFG quirk Kconfig and build strategy")
> I'm puzzled. ca5ab37b19df doesn't *look* like it changes anything.
> thunder_pem_probe() is compiled when CONFIG_PCI_HOST_THUNDER_PEM=y,
> and it calls pci_host_common_probe().
> pci_host_common_probe() is in pci-host-common.c, which is compiled
> when CONFIG_PCI_HOST_COMMON=y. But the declaration below is under
> #ifdef CONFIG_PCI_HOST_GENERIC. Shouldn't it be under #ifdef
> CONFIG_PCI_HOST_COMMON instead?
> It'd be nice to know what actually broke this (if it's not
> ca5ab37b19df) so we can figure out where the fix should be backported.
Right, I misread the commit and got the wrong one. I also ran into a related
problem and will follow up with a new patch that addresses both at once.
Please ignore this version for now.