Re: [PATCH] mm: testcases for RODATA: fix config dependency

From: Kees Cook
Date: Wed Feb 15 2017 - 17:12:42 EST


On Wed, Feb 15, 2017 at 1:00 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 10 Feb 2017 15:36:37 -0800 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> > config DEBUG_RODATA_TEST
>> > bool "Testcase for the marking rodata read-only"
>> > - depends on DEBUG_RODATA
>> > + depends on STRICT_KERNEL_RWX
>> > ---help---
>> > This option enables a testcase for the setting rodata read-only.
>>
>> Great, thanks!
>>
>> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Andrew, do you want to take this patch, since it applies on top of
>> "mm: add arch-independent testcases for RODATA", or do you want me to
>> take both patches into my KSPP tree which has the DEBUG_RODATA ->
>> STRICT_KERNEL_RWX renaming series?
>
> I staged this and mm-add-arch-independent-testcases-for-rodata.patch
> after linux-next and shall merge them after the STRICT_KERNEL_RWX
> rename has gone into mainline.

Awesome, thanks!

-Kees

--
Kees Cook
Pixel Security