[PATCH 3.16 082/306] fuse: invalidate dir dentry after chmod

From: Ben Hutchings
Date: Wed Feb 15 2017 - 18:17:01 EST

3.16.40-rc1 review patch. If anyone has any objections, please let me know.


From: Miklos Szeredi <mszeredi@xxxxxxxxxx>

commit 5e2b8828ff3d79aca8c3a1730652758753205b61 upstream.

Without "default_permissions" the userspace filesystem's lookup operation
needs to perform the check for search permission on the directory.

If directory does not allow search for everyone (this is quite rare) then
userspace filesystem has to set entry timeout to zero to make sure
permissions are always performed.

Changing the mode bits of the directory should also invalidate the
(previously cached) dentry to make sure the next lookup will have a chance
of updating the timeout, if needed.

Reported-by: Jean-Pierre Andrà <jean-pierre.andre@xxxxxxxxxx>
Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
fs/fuse/dir.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1822,14 +1822,22 @@ error:
static int fuse_setattr(struct dentry *entry, struct iattr *attr)
struct inode *inode = entry->d_inode;
+ int ret;

if (!fuse_allow_current_process(get_fuse_conn(inode)))
return -EACCES;

if (attr->ia_valid & ATTR_FILE)
- return fuse_do_setattr(entry, attr, attr->ia_file);
+ ret = fuse_do_setattr(entry, attr, attr->ia_file);
- return fuse_do_setattr(entry, attr, NULL);
+ ret = fuse_do_setattr(entry, attr, NULL);
+ if (!ret) {
+ /* Directory mode changed, may need to revalidate access */
+ if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
+ fuse_invalidate_entry_cache(entry);
+ }
+ return ret;

static int fuse_getattr(struct vfsmount *mnt, struct dentry *entry,