[PATCH 3.16 162/306] drm/radeon: drop register readback in cayman_cp_int_cntl_setup

From: Ben Hutchings
Date: Wed Feb 15 2017 - 18:42:35 EST

3.16.40-rc1 review patch. If anyone has any objections, please let me know.


From: Lucas Stach <dev@xxxxxxxxxx>

commit 537b4b462caa8bfb9726d9695b8e56e2d5e6b41e upstream.

The read is taking a considerable amount of time (about 50us on this
machine). The register does not ever hold anything other than the ring
ID that is updated in this exact function, so there is no need for
the read modify write cycle.

This chops off a big chunk of the time spent in hardirq disabled
context, as this function is called multiple times in the interrupt
handler. With this change applied radeon won't show up in the list
of the worst IRQ latency offenders anymore, where it was a regular

Reviewed-by: Christian KÃnig <christian.koenig@xxxxxxx>
Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
drivers/gpu/drm/radeon/ni.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/gpu/drm/radeon/ni.c
+++ b/drivers/gpu/drm/radeon/ni.c
@@ -1333,9 +1333,7 @@ static void cayman_pcie_gart_fini(struct
void cayman_cp_int_cntl_setup(struct radeon_device *rdev,
int ring, u32 cp_int_cntl)
- u32 srbm_gfx_cntl = RREG32(SRBM_GFX_CNTL) & ~3;
- WREG32(SRBM_GFX_CNTL, srbm_gfx_cntl | (ring & 3));
WREG32(CP_INT_CNTL, cp_int_cntl);