Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task()
From: Steven Rostedt
Date: Wed Feb 15 2017 - 21:33:50 EST
On Wed, 15 Feb 2017 21:31:50 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Thu, 16 Feb 2017 11:17:58 +0900
> Byungchul Park <byungchul.park@xxxxxxx> wrote:
> > Juri and steven, thank you very much for reviewing it.
> > I'm not sure and familiar with... Should I add your 'reviewed by' into
> > my patches by myself?
> No, it's the maintainer's job to add these tags when they take your
> patch. If you were to resend the patch because of a minor change
> (something a reviewer told you to make but still gave you their
> reviewed-by tag), then you could add it. Or if you have a patch series
> and resend a new series, you can add the reviewed-by tags to the
> patches that were not changed. But if you were to change a patch, then
> you need to ask the reviewer to give their tag again, because they need
> to review the changes made before their tag should go on it.
I just noticed that you sent a v2 of the patch we reviewed. Since you
didn't change it, you could have added our review-by tags. That makes
it a bit easier for maintainers to know.