Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

From: Greg KH
Date: Thu Feb 16 2017 - 11:39:26 EST


On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote:
> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva:
> > The condition modex % 16 cannot be true when modex value is equal to
> > 640
> > The condition du & 0xff cannot be true when du value is equal to
> > 0x1400
>
>
> Sorry for speaking up so late, but this is not a good idea.
> We lose the knowledge how to do this correctly, if we want
> to change the resolution.

Given the age of this driver, I doubt that will ever happen :)

thanks,

greg k-h