Re: [PATCH v3 3/9] raid5: Don't reinvent the wheel but use existing llist API

From: Shaohua Li
Date: Thu Feb 16 2017 - 17:48:53 EST


On Tue, Feb 14, 2017 at 04:26:24PM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

This one has no dependence of previous patches, so I added to md tree.

Thanks,
Shaohua
> Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
> ---
> drivers/md/raid5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 36c13e4..22a0326 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -353,17 +353,15 @@ static void release_inactive_stripe_list(struct r5conf *conf,
> static int release_stripe_list(struct r5conf *conf,
> struct list_head *temp_inactive_list)
> {
> - struct stripe_head *sh;
> + struct stripe_head *sh, *t;
> int count = 0;
> struct llist_node *head;
>
> head = llist_del_all(&conf->released_stripes);
> head = llist_reverse_order(head);
> - while (head) {
> + llist_for_each_entry_safe(sh, t, head, release_list) {
> int hash;
>
> - sh = llist_entry(head, struct stripe_head, release_list);
> - head = llist_next(head);
> /* sh could be readded after STRIPE_ON_RELEASE_LIST is cleard */
> smp_mb();
> clear_bit(STRIPE_ON_RELEASE_LIST, &sh->state);
> --
> 1.9.1
>