Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match

From: Corentin Labbe
Date: Fri Feb 17 2017 - 03:20:19 EST


On Wed, Feb 15, 2017 at 07:34:57AM -0800, Frank Rowand wrote:
> On 02/15/17 06:22, Corentin Labbe wrote:
> > This symbol will be needed for the dwmac-sun8i ethernet driver.
> > For letting it to be build as module, of_device_compatible_match need to
> > be exported.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> > ---
> > drivers/of/base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > index df6f6e3..fba351b 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
> >
> > return score;
> > }
> > +EXPORT_SYMBOL(of_device_compatible_match);
> >
> > /**
> > * of_machine_is_compatible - Test root of device tree for a given compatible value
> >
>
>
>
> Rob's reply to the last person who requested that:
>
> It's not missing because no modules use it. It's generally preferred
> to use a match table and of_match_node.
>
> -Frank

I replace of_device_compatible_match like you said and it works.
Thanks
Corentin Labbe