Re: [PATCH 5/5] perf record: Add -a as a default target
From: Arnaldo Carvalho de Melo
Date: Fri Feb 17 2017 - 09:28:24 EST
Em Fri, Feb 17, 2017 at 03:00:58PM +0100, Jiri Olsa escreveu:
> Adding system wide (-a) option as a default target
> if non is specified.
>
> # perf record
> Warning: No target specified, setting system-wide collection (-a).
Ditto, this warning will get annoying after a while...
> ...
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: David Ahern <dsahern@xxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Link: http://lkml.kernel.org/n/tip-tq11of2qlz8kxpxzva05d54l@xxxxxxxxxxxxxx
> ---
> tools/perf/Documentation/perf-record.txt | 2 +-
> tools/perf/builtin-record.c | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index 27256bc68eda..b16003ec14a7 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -157,7 +157,7 @@ OPTIONS
>
> -a::
> --all-cpus::
> - System-wide collection from all CPUs.
> + System-wide collection from all CPUs (default if no target is specified).
>
> -p::
> --pid=::
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 6cd6776052e7..dab23f6b10f3 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -1677,8 +1677,10 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
>
> argc = parse_options(argc, argv, record_options, record_usage,
> PARSE_OPT_STOP_AT_NON_OPTION);
> - if (!argc && target__none(&rec->opts.target))
> - usage_with_options(record_usage, record_options);
> + if (!argc && target__none(&rec->opts.target)) {
> + pr_warning("Warning: No target specified, setting system-wide collection (-a).\n");
> + rec->opts.target.system_wide = true;
> + }
>
> if (nr_cgroups && !rec->opts.target.system_wide) {
> usage_with_options_msg(record_usage, record_options,
> --
> 2.7.4