Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init

From: MichaÅ Zegan
Date: Fri Feb 17 2017 - 14:49:37 EST




W dniu 17.02.2017 o 20:44, Kevin Hilman pisze:
> MichaÅ Zegan <webczat@xxxxxxxxxxxxx> writes:
>
>> At the end of function meson_mmc_clk_init, the cfg_div clock was
>> prepared, enabled and configured, but then immediately disabled due to bogus if statements.
>> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning.
>> Fix that by changing the code to disable clock only when it failed to be configured.
>>
>> Signed-off-by: MichaÅ Zegan <webczat@xxxxxxxxxxxxx>
> I believe this one is not needed any more after Heiner's cleanups?
I think it is not needed, yes.
>
> Kevin