Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

From: Andrew Lunn
Date: Fri Feb 17 2017 - 16:39:02 EST


On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote:
> The 6390 family of Marvell chips uses 5 bits to describe the ToPort and
> FromPort values of PortVec in the ATU Move operation, while older
> switches use 0xf.

Hi Vivien

Since you say 5 bits for 6390, it would be better to say 4 bits for
older switches.

Otherwise:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew