Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

[Adan Hawthorn]

Thank you, Joe.

Please remove this patch at this time; it was sent in error.

On Fri, Feb 17, 2017 at 6:04 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote:
>> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
>> usually wrong: see Documentation/process/volatile-considered-harmful.rst."
>
> Why are you sure the volatile use is not necessary?
>
>> Signed-off-by: Nathan Howard <adanhawthorn@xxxxxxxxx>
>> ---
>>  drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
>> index 2f9d1c9..08f7ad6 100644
>> --- a/drivers/staging/bcm2835-audio/bcm2835.h
>> +++ b/drivers/staging/bcm2835-audio/bcm2835.h
>> @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
>>       struct semaphore buffers_update_sem;
>>       struct semaphore control_sem;
>>       spinlock_t lock;
>> -     volatile unsigned int control;
>> -     volatile unsigned int status;
>> +     unsigned int control;
>> +     unsigned int status;
>>
>>       int open;
>>       int running;