Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

[Julia Lawall]

On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:

>
>
> On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote:
>
>
>       On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:
>
>       >
>       >
>       > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia
>       Lawall wrote:
>       >
>       >
>       > Â Â Â On Sat, 18 Feb 2017, simran singhal wrote:
>       >
>       > Â Â Â > Align * on a line, to conform to the kernal coding
>       > Â Â Â > style for block comments.
>       >
>       > Â Â Â It is not clear what is means to align * on a line.
>       ÂWhat line?
>       >
>       > Â Â Â What has been done is to add a space at the beginning of
>       the
>       > Â Â Â line. ÂBut
>       > Â Â Â then the line goes over 80 characters and doesn't line
>       up any
>       > Â Â Â more on the
>       > Â Â Â right side. ÂI would guess that you should have gotten a
>       new
>       > Â Â Â warning by
>       > Â Â Â having gone over 80 characters. Fixing one warning
>       should not
>       > Â Â Â introduce a
>       > Â Â Â new one, especially for something purely decorative,
>       like this.
>       >
>       > Â Â Â julia
>       >
>       > ÂJulia, I am not getting any new warning. It's not gone over
>       80 characters.
>
>       OK, it looked like it would be too long on my screen.
>
>       Are the right sides of the * lines lined up after the change?
>
>       julia
>
> In the right sides of the * lines, stars are lined up.Â

OK, thanks.

julia

>       > Â
>       > Â Â Â >
>       > Â Â Â > Signed-off-by: simran singhal <singhal...@xxxxxxxxx>
>       > Â Â Â > ---
>       > Â Â Â > Âdrivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>       > Â Â Â > Â1 file changed, 1 insertion(+), 1 deletion(-)
>       > Â Â Â >
>       > Â Â Â > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h
>       > Â Â Â b/drivers/staging/rtl8192e/rtl819x_HT.h
>       > Â Â Â > index 6eb018f..48d101a 100644
>       > Â Â Â > --- a/drivers/staging/rtl8192e/rtl819x_HT.h
>       > Â Â Â > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
>       > Â Â Â > @@ -11,7 +11,7 @@
>       > Â Â Â > Â *
>       > Â Â Â > Â * Contact Information:
>       > Â Â Â > Â * wlanfae <wla...@xxxxxxxxxxx>
>       > Â Â Â>-*************************************************************************
>       *
>       > Â Â Â ****/
>       > Â Â Â >+**************************************************************************
>       *
>       > Â Â Â ***/
>       > Â Â Â > Â#ifndef _RTL819XU_HTTYPE_H_
>       > Â Â Â > Â#define _RTL819XU_HTTYPE_H_
>       > Â Â Â >
>       > Â Â Â > --
>       > Â Â Â > 2.7.4
>       > Â Â Â >
>       > Â Â Â > --
>       > Â Â Â > You received this message because you are subscribed
>       to the
>       > Â Â Â Google Groups "outreachy-kernel" group.
>       > Â Â Â > To unsubscribe from this group and stop receiving
>       emails from
>       > Â Â Â it, send an email to outreachy-kern...@xxxxxxxxxxxxxxxxx
>       > Â Â Â > To post to this group, send email to
>       > Â Â Â outreach...@xxxxxxxxxxxxxxxxx
>       > Â Â Â > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28
>       908%4
>       > Â Â Â 0singhal-Inspiron-5558.
>       > Â Â Â > For more options, visit
>       https://groups.google.com/d/optout.
>       > Â Â Â >
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups
>       > "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an
>       > email to outreachy-kern...@xxxxxxxxxxxxxxxxx
>       > To post to this group, send email to
>       outreach...@xxxxxxxxxxxxxxxxx
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d-
>       8d66-
>       > afc735f3a8f6%40googlegroups.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>       >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/da5a9bc2-9a49-4fac-b7e8-
> eb686d14ad1e%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>