Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.

[Hillf Danton]

On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote: 
> 
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>

Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx>

> ---
>  mm/huge_memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
> 
>  	if (page_nid != -1)
>  		task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> -				vmf->flags);
> +				flags);
> 
>  	return 0;
>  }
> --
> 2.7.4