Re: [PATCHv2 4/5] perf stat: Add -a as a default target

From: Jiri Olsa
Date: Mon Feb 20 2017 - 02:13:25 EST


On Sat, Feb 18, 2017 at 06:52:25PM +0100, Borislav Petkov wrote:
> On Fri, Feb 17, 2017 at 06:48:13PM +0100, Boris Petkov wrote:
> > LGTM.
> >
> > Acked-by: me
>
> Well, it looks good but actually trying it is a different story. For
> example:
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1
>
> still says <not supported> because argc is not 0.
>
> So how about the below diff instead?
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/
>
> without args dumps the usage message and
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1
>
> actually does the system-wide thing:
>
> Performance counter stats for 'system wide':
>
> 196,469 amd_nb/event=0xe0,umask=0x1f/
>
> 1.001815180 seconds time elapsed
>
> Hmmm?

ugh, I thought it was too easy ;-)

it looks good to me

thanks,
jirka