Re: [PATCH] iio: adc: xilinx: Fix error handling

From: Lars-Peter Clausen
Date: Mon Feb 20 2017 - 03:35:27 EST


On 02/19/2017 09:29 PM, Christophe JAILLET wrote:
> Reorder error handling labels in order to match the way resources have
> been allocated.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks, looks good.

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

I think there is one more issue

ret = xadc->ops->setup(pdev, indio_dev, irq);
if (ret)
goto err_free_samplerate_trigger;

should be

goto err_clk_disable_unprepare;