Re: [PATCH] vfs: fix uninitialized flags in splice_to_pipe()

From: Christoph Hellwig
Date: Mon Feb 20 2017 - 04:22:24 EST


On Thu, Feb 16, 2017 at 05:49:02PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxxxxx>
>
> Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused
> part of the pipe ring buffer. Previously splice_to_pipe() left the flags
> value alone, which could result in incorrect behavior.
>
> Uninitialized flags appears to have been there from the introduction of the
> splice syscall.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>