Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups

[Matthias Brugger]

On 19/02/17 02:23, Eduardo Valentin wrote:
> On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote:
> > Hi, Matthias,
> >
> > On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
> > > On 02/08/2017 06:31 AM, Dawei Chien wrote:
> > > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
> > > > However, Currently thermal driver don't need read TEMP_MSR3 since
> > > > thermal controller only use 3 sensors for each thermal bank.
> > > >
> > > > Signed-off-by: Dawei Chien <dawei.chien@xxxxxxxxxxxx>
> > > > ---
> > >
> > > Actually the commit message should state:
> > > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
> > >
> > > ...and get backported to v4.9 and v4.10.
> > >
> > > Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> > >
> > > Regards,
> > > Matthias
> >
> > Thank you for your review. I would add below commit message on next
> > version. However, currently 8173 thermal driver would not read TEMP_MSR3
> > since thermal driver only use 3 sensors on each bank, this patch would
> > not effect temperature.
> > Only if thermal driver use 4 sensors on any thermal bank, would read
> > third sensor two times, and lose fourth sensor of vale.
> > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>
> Please send a new version with the tag in the commit message.

And don't forget to add stable@xxxxxxxxxxxxxxx so that the fix ends up 
in the older kernels as well.

Regards,
Matthias