Re: next-20170220 failed to build on PowerPC

[Abdul Haleem]

On 2017-02-20 16:25, abdul wrote:
> Hi,
>
> next-20170220 fails to build on Power 8 (PowerVM LPAR) with these 
> errors.
>
> with same config, next-20170215 builds fine.
>
> the config file used is attached, by default
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE was not set.
>
> (X) Simple tick based cputime accounting
> ( ) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting
>
> arch/powerpc/kernel/time.c: In function ârunning_clockâ:
> arch/powerpc/kernel/time.c:712:25: error: implicit declaration of
> function âcputime_to_nsecsâ
> [-Werror=implicit-function-declaration]
>    return local_clock() -
> cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> 		  ^
> cc1: all warnings being treated as errors
> make[1]: *** [arch/powerpc/kernel/time.o] Error 1
> make[1]: *** Waiting for unfinished jobs....,
>
> Note*: Problem is not seen when CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is 
> enabled i.e
>
> ( ) Simple tick based cputime accounting
> (X) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting

Bisecting resulted in below commit causing the build break.

commit f22d6df0b23e66b6d9058e2570402606a6ad069a
Author: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Date:   Tue Jan 31 04:09:43 2017 +0100

    sched/cputime: Remove jiffies based cputime

    This cputime_t implementation is now unused, we can remove it.

    Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
    Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
    Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
    Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
    Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
    Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
    Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
    Cc: Paul Mackerras <paulus@xxxxxxxxx>
    Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
    Cc: Rik van Riel <riel@xxxxxxxxxx>
    Cc: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
    Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
    Cc: Tony Luck <tony.luck@xxxxxxxxx>
    Cc: Wanpeng Li <wanpeng.li@xxxxxxxxxxx>
    Link: 
http://lkml.kernel.org/r/1485832191-26889-28-git-send-email-fweisbec@xxxxxxxxx
    Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>


Regard's
Abdul Haleem
IBM Linux Technology Center.