Re: Unknown ALPS touchpad

[Pali RohÃr]

On Tuesday 21 February 2017 03:10:06 Masaki Ota wrote:
> Hi, Pali,
> 
> I know these devices, and they are supported in new kernel.
> I'm not sure when they are supported from.
> In alps.c has below code.
> 
> static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)
> {...
> ...
> 		if (e7[0] == 0x73 && e7[1] == 0x03 && e7[2] == 0x50 &&
> 			   ec[0] == 0x73 && (ec[1] == 0x01 || ec[1] == 0x02)) {
> 			protocol = &alps_v5_protocol_data;
> 		} else if (ec[0] == 0x88 &&
> 			   ((ec[1] & 0xf0) == 0xb0 || (ec[1] & 0xf0) == 0xc0)) {
> 			protocol = &alps_v7_protocol_data;}
> }

Ou, sorry I have missed this checks for ec[0] == 0x88.

Marcos, so conclusion is that all those ALPS devices are already
supported by last mainline kernel. So you can close those bug reports.
If you need with git blame you can identify commit in which was support
added and then you can find in which kernel version was particular
commit first time.

> 
> E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data
> E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
> E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data
> 
> Best Regards,
> Masaki Ota
> -----Original Message-----
> From: Pali RohÃr [mailto:pali.rohar@xxxxxxxxx] 
> Sent: Tuesday, February 21, 2017 12:51 AM
> To: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>; åç çå Masaki Ota <masaki.ota@xxxxxxxxxxx>
> Cc: John Preston <wcerfgba@xxxxxxxxxx>; Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Unknown ALPS touchpad
> 
> Adding Masaki into discussion.
> 
> On Sunday 19 February 2017 20:01:07 Marcos Paulo de Souza wrote:
> > There are other open bugs mentioning the same problem, with similar ALPS devices:
> > https://bugzilla.kernel.org/show_bug.cgi?id=57841
> 
> Unknown ALPS touchpad: E7=73 03 50, EC=73 02 02
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=43931
> 
> Unknown ALPS touchpad: E7=73 00 14, EC=10 00 64
> 
> Should be supported since commit 95f75e91 which was introduced in Linux version v3.13-rc4.
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=80181
> 
> Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 22
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=67941
> 
> Unknown ALPS touchpad: E7=73 03 0a, EC=88 b3 18
> 
> > This one without even a dmesg output:
> > https://bugzilla.kernel.org/show_bug.cgi?id=84081
> 
> Sorry, this one does not contain any useful information.
> 
> > Maybe they are related, or  also need some touch to let them being discovered as proper devices?
> 
> Masaki, can you look at those unknown ALPS touchpad identifiers and provide some information about protocol which they are using?
> 
> Basically touchpads with these identifiers are unsupported by last kernel version:
> 
> E7=73 03 50, EC=73 02 02
> E7=73 03 0a, EC=88 b3 22
> E7=73 03 0a, EC=88 b3 18
> 
> --
> Pali RohÃr
> pali.rohar@xxxxxxxxx

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx