Re: [PATCH] tty/serial: atmel: remove cache when unnecessary

[Richard Genoud]

2017-02-21 13:03 GMT+01:00 Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxxxxxxxxx>:
> struct cache is only used in suspend/resume. Exclude it when PM is not
> selected.
>
> Suggested-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
Acked-by: Richard Genoud <richard.genoud@xxxxxxxxx>
> ---
>  drivers/tty/serial/atmel_serial.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index dcebb28ffbc4..f0d4894267c2 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -175,6 +175,7 @@ struct atmel_uart_port {
>         unsigned int            pending_status;
>         spinlock_t              lock_suspended;
>
> +#ifdef CONFIG_PM
>         struct {
>                 u32             cr;
>                 u32             mr;
> @@ -185,6 +186,7 @@ struct atmel_uart_port {
>                 u32             fmr;
>                 u32             fimr;
>         } cache;
> +#endif
>
>         int (*prepare_rx)(struct uart_port *port);
>         int (*prepare_tx)(struct uart_port *port);
> --
> 2.11.0
>

Thanks !