Re: [PATCH Speakup v2] return same error value from spk_set_key_info

[Samuel Thibault]

Pranay Kr. Srivastava, on mar. 21 févr. 2017 19:14:38 +0530, wrote:
> +	if (key_data_len + SHIFT_TBL_SIZE + 4 >= sizeof(spk_key_buf)) {
> +		pr_debug("key_data_len = %d, SHIFT_TBL_SIZE + 4 = %d,\t"
> +			 "sizeof(spk_key_buf) = %lu\n", key_data_len,
> +			 SHIFT_TBL_SIZE + 4, sizeof(spk_key_buf));

Well, that's very technical, and not useful to an actual user :)
Rather print
			"too many key infos (%d bytes over %d)",
			key_data_len + SHIFT_TBL_SIZE + 4,
			sizeof(spk_key_buf)

> +		if (ch >= SHIFT_TBL_SIZE) {
> +			pr_debug("ch = %d, SHIFT_TBL_SIZE = %d\n", ch,
> +				 SHIFT_TBL_SIZE);

similarly, rather
			"ch %d is not a valid shift state (maximum %d)", ch, SHIFT_TBL_SIZE

> +		if (ch >= MAX_KEY) {
> +			pr_debug("ch = %d, MAX_KEY = %d\n", ch, MAX_KEY);

and
			"ch %d is not a valid keycode (maximum %d)", ch, MAX_KEY

Samuel