Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info

[Hari Bathini]

Hi Jiri,


On Wednesday 08 February 2017 06:27 PM, Jiri Olsa wrote:
> On Wed, Feb 08, 2017 at 02:01:49PM +0530, Hari Bathini wrote:
> > This patch updates perf tool to examine PERF_RECORD_NAMESPACES events
> > emitted by the kernel when fork, clone, setns or unshare are invoked.
> > Also, it synthesizes PERF_RECORD_NAMESPACES events for processes that
> > were running prior to invocation of perf record, the data for which
> > is taken from /proc/$PID/ns. These changes make way for analyzing
> > events with regard to namespaces.
> >
> > Signed-off-by: Hari Bathini <hbathini@xxxxxxxxxxxxxxxxxx>
> > ---
> >   tools/include/uapi/linux/perf_event.h |   38 +++++++++
> >   tools/perf/builtin-annotate.c         |    1
> >   tools/perf/builtin-diff.c             |    1
> >   tools/perf/builtin-inject.c           |   14 +++
> >   tools/perf/builtin-kmem.c             |    1
> >   tools/perf/builtin-kvm.c              |    2
> >   tools/perf/builtin-lock.c             |    1
> >   tools/perf/builtin-mem.c              |    1
> >   tools/perf/builtin-record.c           |   33 +++++++-
> >   tools/perf/builtin-report.c           |    1
> >   tools/perf/builtin-sched.c            |    1
> >   tools/perf/builtin-script.c           |   41 +++++++++
> >   tools/perf/builtin-trace.c            |    3 -
> >   tools/perf/perf.h                     |    1
> >   tools/perf/util/Build                 |    1
> >   tools/perf/util/data-convert-bt.c     |    2
> >   tools/perf/util/event.c               |  143 ++++++++++++++++++++++++++++++++-
> >   tools/perf/util/event.h               |   19 ++++
> >   tools/perf/util/evsel.c               |    3 +
> >   tools/perf/util/machine.c             |   34 ++++++++
> >   tools/perf/util/machine.h             |    3 +
> >   tools/perf/util/namespaces.c          |   35 ++++++++
> >   tools/perf/util/namespaces.h          |   26 ++++++
> >   tools/perf/util/session.c             |    7 ++
> >   tools/perf/util/thread.c              |   44 ++++++++++
> >   tools/perf/util/thread.h              |    6 +
> >   tools/perf/util/tool.h                |    2
> >   27 files changed, 450 insertions(+), 14 deletions(-)
> >   create mode 100644 tools/perf/util/namespaces.c
> >   create mode 100644 tools/perf/util/namespaces.h
> could you please split this patch into logically separated changes, like:
>    - adding PERF_RECORD_NAMESPACES event with perf_event__process_namespaces
>      machinery
>    - synthesize support (perf_event__synthesize_namespaces) for record
>    - script print support
>    - perf_event__fprintf print support
>
> or any other split that'd make sense, it's too many changes for one patch now

Thanks for the review.
Posted v7 with the changes included..

- Hari