Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

[David Miller]

From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>
Date: Mon, 20 Feb 2017 14:58:41 +0300

> Include <sys/socket.h> (guarded by ifndef __KERNEL__) to fix
> the following linux/if.h userspace compilation errors:

Wouldn't it be so much better to do this in include/uapi/linux/socket.h?

I mean, look at the comment right by the change you are making:

> @@ -24,6 +24,10 @@
>  #include <linux/socket.h>		/* for "struct sockaddr" et al	*/
                                           ^^^^^^^^^^^^^^^^^^^^^^^

Anyone including linux/socket.h is trying to obtain that type.