Re: [PATCH v3 4/5] vfs: Add timestamp_truncate() api
From: Deepa Dinamani
Date: Tue Feb 21 2017 - 13:18:59 EST
>>> fs/inode.c:2125: warning: Excess function parameter 'gran' description in 'timestamp_truncate'
> 2116 /**
> 2117 * fs_timespec_trunc - Truncate timespec to a granularity
> 2118 * @t: Timespec
> 2119 * @gran: Granularity in ns.
> 2120 *
> 2121 * Truncate a timespec to a granularity. Always rounds down. gran must
> 2122 * not be 0 nor greater than a second (NSEC_PER_SEC, or 10^9 ns).
> 2123 */
> 2124 struct timespec timestamp_truncate(struct timespec t, struct inode *inode)
>> 2125 {
> 2126 struct super_block *sb = inode->i_sb;
> 2127 unsigned int gran = sb->s_time_gran;
This because the comment does not match the actual function signature:
The gran param mentioned in the comment is not actually part of
function signature.
I will fix the comment in the next version.
-Deepa