checkpatch suspected false positive
From: Tobin C. Harding
Date: Tue Feb 21 2017 - 18:02:17 EST
Checkpatch may be giving a false positive of type CONST_STRUCT when
parsing files in drivers/staging/comedi/drivers.
$ pwd
build/kernel/linux-trees/gregKH/staging/
$ cd drivers/staging/comedi/drivers
$ checkpatch --terse --show-types *.c | grep CONST_STRUCT
addi_apci_3501.c:97: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:972: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:1006: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:659: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:667: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:668: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
ni_670x.c:212: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
snippet from das16.c
/* get any user-defined input range */
if (pg_type == das16_pg_none && (min || max)) {
struct comedi_lrange *lrange;
struct comedi_krange *krange;
/* allocate single-range range table */
lrange = comedi_alloc_spriv(s, sizeof(*lrange) + sizeof(*krange));
if (!lrange)
return &range_unknown;
/* initialize ai range */
lrange->length = 1;
krange = lrange->range;
krange->min = min;
krange->max = max;
krange->flags = UNIT_volt;
return lrange;
}
>From snippet it may be seen that struct comedi_lrange *lrange should
not be const.
In the event that I am in the wrong and checkpatch is correct please
feel free to bluntly correct me.
thanks,
Tobin.