Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps

[Shaohua Li]

On Wed, Feb 22, 2017 at 11:47:21AM +0900, Minchan Kim wrote:
> On Fri, Feb 03, 2017 at 03:33:22PM -0800, Shaohua Li wrote:
> > Cc: Michal Hocko <mhocko@xxxxxxxx>
> > Cc: Minchan Kim <minchan@xxxxxxxxxx>
> > Cc: Hugh Dickins <hughd@xxxxxxxxxx>
> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> > Cc: Rik van Riel <riel@xxxxxxxxxx>
> > Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Shaohua Li <shli@xxxxxx>
> > ---
> >  fs/proc/task_mmu.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index ee3efb2..8f2423f 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> > @@ -440,6 +440,7 @@ struct mem_size_stats {
> >  	unsigned long private_dirty;
> >  	unsigned long referenced;
> >  	unsigned long anonymous;
> > +	unsigned long lazyfree;
> >  	unsigned long anonymous_thp;
> >  	unsigned long shmem_thp;
> >  	unsigned long swap;
> > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page,
> >  	int i, nr = compound ? 1 << compound_order(page) : 1;
> >  	unsigned long size = nr * PAGE_SIZE;
> >  
> > -	if (PageAnon(page))
> > +	if (PageAnon(page)) {
> >  		mss->anonymous += size;
> > +		if (!PageSwapBacked(page))
> 
> How about this?
> 
> 		if (!PageSwapBacked(page) && !dirty && !PageDirty(page))

Yes, already fixed like this.

Thanks,
Shaohua