Re: [PATCH v7 0/8] perf: add support for analyzing events for containers
From: Jiri Olsa
Date: Wed Feb 22 2017 - 08:52:22 EST
On Wed, Feb 22, 2017 at 06:10:28PM +0530, Hari Bathini wrote:
> Hi Jirka,
>
>
> On Wednesday 22 February 2017 04:41 PM, Jiri Olsa wrote:
> > On Tue, Feb 21, 2017 at 07:31:11PM +0530, Hari Bathini wrote:
> > > Currently, there is no trivial mechanism to analyze events based on
> > > containers. perf -G can be used, but it will not filter events for the
> > > containers created after perf is invoked, making it difficult to assess/
> > > analyze performance issues of multiple containers at once.
> > >
> > > This patch-set is aimed at addressing this limitation by introducing a
> > > new PERF_RECORD_NAMESPACES event that records namespaces related info.
> > > As containers are created with namespaces, the new data can be used to
> > > in assessment/analysis of multiple containers.
> > >
> > > The first patch introduces PERF_RECORD_NAMESPACES in kernel while the
> > > second patch makes the corresponding changes in perf tool to read this
> > > PERF_RECORD_NAMESPACES events. The third patch demonstrates analysis
> > > of containers with this data by adding a cgroup identifier column in
> > > perf report, which contains the cgroup namespace's device and inode
> > > numbers. This is based on the assumption that each container is created
> > > with it's own cgroup namespace. The third patch has scope for improvement
> > > based on the conventions a container is attributed with, going forward.
> > >
> > > Changes from v6:
> > > * Updated changelog of patch 1
> > > * Split patch 2 into smaller patches
> > > * Updated record and script documenatation
> > > * Dropped name field from ns_link_info struct
> > what's this version based on? I can't cleanly apply it neither
> > on tip's perf/core or master or Arnaldo's perf/core
>
> That's odd. I based my patches against tip's perf/core
> To be precise, the patches apply cleanly on top of commit
> 0c8967c9df230d2c4dde6649f410b62e01806c22.
got it now, thanks
jirka