Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error
From: Frederic Weisbecker
Date: Wed Feb 22 2017 - 23:02:47 EST
On Thu, Feb 23, 2017 at 08:34:15AM +1100, Michael Ellerman wrote:
> Frederic Weisbecker <fweisbec@xxxxxxxxx> writes:
>
> > This type conversion is a leftover that got ignored during the kcpustat
> > conversion to nanosecs, resulting in build breakage with config having
> > CONFIG_NO_HZ_FULL=y.
> >
> > arch/powerpc/kernel/time.c: In function 'running_clock':
> > arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
> > return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> >
> > All we need is to remove it.
> >
> > Reported-by: Abdul Haleem <abdhalee@xxxxxxxxxxxxxxxxxx>
> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > Cc: Oliver O'Halloran <oohall@xxxxxxxxx>
> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>
> LGTM.
>
> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>
>
> Are you going to send this to Linus, or should I?
I would prefer you send it to Linus if you don't mind.
The fate of a powerpc patch sent by me directly to Linus is
anything but predictable :o)
Thanks.