Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

[Joe Perches]

On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>  	if (!spk_quiet_boot)
>  		synth_printf("%s found\n", synth->long_name);
>  	if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> -							 &synth->attributes) < 0)
> +		&synth->attributes) < 0)

Better would be

	if (synth->attributes.name &&
	    sysfs_create_group(speakup_kobj, &synth->attributes) < 0)