Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform

[Shanker Donthineni]

On 02/23/2017 02:46 PM, Timur Tabi wrote:
> On 02/23/2017 02:02 PM, Shanker Donthineni wrote:
> > The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has
> > been added to fix the hardware bug but causing a system crash. The
>
> "causes"
>
> > value of the register x1 which contains 'struct mm_struct *' should
> > be preserved inside macro pre_ttbr0_update_workaround.
>
> The subject line seems a bit vague and alarmist to me.  In my opinion, 
> this is more descriptive:
>
> arm64: qcom: pre_ttbr0_update_workaround should not clobber register x1
Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing 
wrong with macro definition itself. Problem with the caller, not passing 
the right arguments.

--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.