Re: [PATCH v4 03/17] x86/mpx, x86/insn: Relocate insn util functions to a new insn-kernel

From: Ricardo Neri
Date: Thu Feb 23 2017 - 17:18:56 EST


On Thu, 2017-02-23 at 18:54 +0800, kbuild test robot wrote:
> >> arch/x86/lib/insn-eval.c:106:21: error: static declaration of
> 'insn_get_addr_ref' follows non-static declaration
> static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
> ^~~~~~~~~~~~~~~~~
> In file included from arch/x86/lib/insn-eval.c:10:0:
> arch/x86/include/asm/insn-eval.h:14:14: note: previous declaration
> of 'insn_get_addr_ref' was here
> void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs
> *regs);
> ^~~~~~~~~~~~~~~~~
> arch/x86/lib/insn-eval.c:106:21: warning: 'insn_get_addr_ref'
> defined but not used [-Wunused-function]
> static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
> ^~~~~~~~~~~~~~~~~
>
> vim +/insn_get_addr_ref +106 arch/x86/lib/insn-eval.c

Uh! This escaped my tests after many rebases. I will correct it.

Thanks and BR,
Ricardo