Re: [PATCH v4 05/24] openrisc: head: refactor out tlb flush into it's own function

[Jonas Bonn]

On 02/24/2017 11:54 AM, Stefan Kristiansson wrote:
> eOn Fri, Feb 24, 2017 at 10:57:19AM +0100, Jonas Bonn wrote:
> > On 02/24/2017 05:32 AM, Stafford Horne wrote:
> > > From: Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> > >
> > > This brings it inline with the other setup oprations done like the cache
> > > enables _ic_enable and _dc_enable.  Also, this is going to make it
> > > easier to initialize additional cpu's when smp is introduced.
> > This patch confuses me.  The TLB flush is moved to a point after MMU's are
> > enabled.  The TLB flush should happen before enabling the MMU, shouldn't it?
> It still happens before the MMUs are enabled, the patch only refactors the code
> out into a function that is called from the place where it was open coded
> before.

Right.  What's the point of moving it then?

/Jonas

> Stefan