Re: [PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP
From: Ricardo Neri
Date: Fri Feb 24 2017 - 14:36:29 EST
On Fri, 2017-02-24 at 11:11 -0800, Andy Lutomirski wrote:
> > In a previous version Andy Lutomirsky suggested that
> > if (user_mode(regs) && (fixup_umip_exception(regs) == 0))
> >
> > was easier to read :). Although at the time fixup_umip_exception
> > returned a numeric value. Now it only returns true/false for
> > successful/failed emulation. If with true/false not comparing to
> true
> > makes it easier to read, I will make the change.
>
> I think == true is silly :)
Then I'll make the change.
Thanks and BR,
Ricardo