Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path
From: Stefan Wahren
Date: Fri Feb 24 2017 - 16:41:25 EST
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> hat am 24. Februar 2017 um 20:57 geschrieben:
>
>
> On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > Hi Christophe,
> >
> > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > >done in all other cases in this function.
> > >
> > >Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > >---
> > >Not sure that the error handling path is correct.
> > >Is 'gdev[0]' freed? Should it be?
> >
>
> Yes, but I already sent a patch to fix this and your leak as well and
> Greg merged it.
My leak? I'm confused.